[webkit-changes] [WebKit/WebKit] 1f6b65: DOMMatrix.inverse() returns NaN matrix for small b...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f6b653b2343f60efb7261d8c1502f2fd427cfa6
      https://github.com/WebKit/WebKit/commit/1f6b653b2343f60efb7261d8c1502f2fd427cfa6
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    A LayoutTests/fast/css/matrix-small-values-inverse-expected.txt
    A LayoutTests/fast/css/matrix-small-values-inverse.html
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp

  Log Message:
  -----------
  DOMMatrix.inverse() returns NaN matrix for small but normal values
https://bugs.webkit.org/show_bug.cgi?id=274834
rdar://128960283

Reviewed by Kimmo Kinnunen.

Use std::isnormal(determinant) to check if DOMMatrix (or TransformationMatrix)
isInvertible(). This will replace checking the determinant is less than a defined
SMALL_NUMBER.

* LayoutTests/fast/css/matrix-small-values-inverse-expected.txt: Added.
* LayoutTests/fast/css/matrix-small-values-inverse.html: Added.
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::inverse):
(WebCore::TransformationMatrix::isInvertible const):
(WebCore::TransformationMatrix::inverse const):
(WebCore::TransformationMatrix::isBackFaceVisible const):

Canonical link: https://commits.webkit.org/279588@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications