[webkit-changes] [WebKit/WebKit] 1f22a2: Address post-landing review feedback for Darin for...

Chris Dumez noreply at github.com
Fri May 31 08:05:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f22a2c4c6cad97eb6f29b22aed193e853f57337
      https://github.com/WebKit/WebKit/commit/1f22a2c4c6cad97eb6f29b22aed193e853f57337
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    M Source/WTF/wtf/SHA1.cpp

  Log Message:
  -----------
  Address post-landing review feedback for Darin for 279513 at main
https://bugs.webkit.org/show_bug.cgi?id=274917

Reviewed by Darin Adler.

Address post-landing review feedback for Darin for 279513 at main:
- Use a stack buffer instead of a Vector
- Call CFStringGetBytes() so that we get the numbers of characters
  written in the buffer and avoid a call to strlen()

* Source/WTF/wtf/SHA1.cpp:
(WTF::SHA1::addUTF8Bytes):

Canonical link: https://commits.webkit.org/279579@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list