[webkit-changes] [WebKit/WebKit] c58539: firstRectForCharacterRange returns the original ra...

megangardner noreply at github.com
Fri May 31 07:15:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c585393d11f122301036b3d1b3cc03a64737afa7
      https://github.com/WebKit/WebKit/commit/c585393d11f122301036b3d1b3cc03a64737afa7
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h
    M Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm

  Log Message:
  -----------
  firstRectForCharacterRange returns the original range instead of the actualRange for the first selection rect.
https://bugs.webkit.org/show_bug.cgi?id=274913
rdar://129013199

Reviewed by Wenson Hsieh.

Existing FIXME, pass the actual range of the first
line of the selection instead of just passing back the
range that was passed in.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::firstRectForCharacterRangeAsync):
* Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
(TEST(WKWebViewMacEditingTests, FirstRectForCharacterRange)):

Canonical link: https://commits.webkit.org/279576@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list