[webkit-changes] [WebKit/WebKit] 7e5e04: [Site Isolation] Remove child frames of old main f...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e5e04b40d3eae60d9cd0176061cf2a5ba92511d
      https://github.com/WebKit/WebKit/commit/7e5e04b40d3eae60d9cd0176061cf2a5ba92511d
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebFrameProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Remove child frames of old main frame when committing a provisional page
https://bugs.webkit.org/show_bug.cgi?id=274941
rdar://125374765

Reviewed by Charlie Wolfe.

When a main frame navigates to a new domain, we need the iframes of the previous page to be
removed in the UI process and in all other processes.  This isn't an issue with site isolation
off because we cache or discard the entirety of the previous process when process swapping.
With site isolation, though, the same processes can be reused for the same domains after
main frame navigations.

* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::removeRemoteFrameProcessUse):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, NavigateToDomainAgainWithSPIUse)):

Canonical link: https://commits.webkit.org/279561@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications