[webkit-changes] [WebKit/WebKit] 81447b: [UnifiedPDF] The data detectors page overlay layer...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81447b127263b34c50c5a9093d383d3eff31b6e5
      https://github.com/WebKit/WebKit/commit/81447b127263b34c50c5a9093d383d3eff31b6e5
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm

  Log Message:
  -----------
  [UnifiedPDF] The data detectors page overlay layer doesn't need backing store
https://bugs.webkit.org/show_bug.cgi?id=274936
rdar://129034911

Reviewed by Abrar Rahman Protyasha.

Each DataDetectorHighlight has its own GraphicsLayer into which it paints. Fading is done via
opacity on this layer.

These DD layers are parented in the `OverlayType::Document` page overlay layer, which
can be an empty container with no backing store. So don't request that it use a tiled layer.

We can also remove calls to -setNeedsRepaint in the overlay layer, simplifying
`didInvalidateHighlightOverlayRects()` somewhat.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm:
(WebKit::PDFDataDetectorOverlayController::installOverlayIfNeeded):
(WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects):

Canonical link: https://commits.webkit.org/279559@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications