[webkit-changes] [WebKit/WebKit] d24496: Move all CacheStorageConnection callbacks to Nativ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d244968bca644b6ae5f293054c1c1ba757cef5a2
      https://github.com/WebKit/WebKit/commit/d244968bca644b6ae5f293054c1c1ba757cef5a2
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M Source/WebCore/Modules/cache/CacheStorageConnection.h
    M Source/WebCore/Modules/cache/DOMCache.cpp
    M Source/WebCore/Modules/cache/DOMCacheEngine.h
    M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
    M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
    M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
    M Source/WebCore/dom/ScriptExecutionContext.h
    M Source/WebCore/page/CacheStorageProvider.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/workers/WorkerGlobalScope.cpp
    M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
    M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h

  Log Message:
  -----------
  Move all CacheStorageConnection callbacks to NativePromise
https://bugs.webkit.org/show_bug.cgi?id=274726
rdar://128755510

Reviewed by Jean-Yves Avenard and Sihui Liu.

We move from completion handlers to native promise as a simplification.
We introduce a new enqueueTaskWhenSettled version that can take completion handler and a finalizer.
Covered by existing tests.

* Source/WebCore/Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::clearMemoryRepresentation):
(WebCore::CacheStorageConnection::engineRepresentation):
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
* Source/WebCore/Modules/cache/DOMCacheEngine.h:
* Source/WebCore/Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::retrieveCaches):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
(WebCore::WorkerCacheStorageConnection::retrieveCachesCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::retrieveRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::deleteRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::putRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::clearPendingRequests): Deleted.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::enqueueTaskWhenSettled):
* Source/WebCore/page/CacheStorageProvider.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::clearCacheStorageMemoryRepresentation):
(WebCore::Internals::cacheStorageEngineRepresentation):
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::prepareForDestruction):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:

Canonical link: https://commits.webkit.org/279505@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications