[webkit-changes] [WebKit/WebKit] df735d: [Site Isolation] Back forward items for cross-orig...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df735d5e5a8ab2e4681ea757fed4e94829c06e98
      https://github.com/WebKit/WebKit/commit/df735d5e5a8ab2e4681ea757fed4e94829c06e98
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Back forward items for cross-origin iframe navigations are ignored
https://bugs.webkit.org/show_bug.cgi?id=274804
rdar://128902889

Reviewed by Alex Christensen.

We should only expect an additional back forward item for the initial load of a root child frame.
Separate back forward items are already created when navigating within a child frame (even without site
isolation), so we don’t need to set any additional state on those items. This was causing us to skip
over cross-origin iframe navigations when moving in the back forward list. Going back/forward to
cross-origin iframes still doesn’t work correctly for different reasons.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
If the process being navigated from is the parent frame’s process we know it is an initial iframe load.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, CanGoBackAfterNavigatingFrameCrossOrigin)):

Canonical link: https://commits.webkit.org/279486@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications