[webkit-changes] [WebKit/WebKit] bd4296: REGRESSION(276827 at main): A large animated image wi...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd4296e26d45bccca513cdf21af3a1f8fa51c229
      https://github.com/WebKit/WebKit/commit/bd4296e26d45bccca513cdf21af3a1f8fa51c229
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    A LayoutTests/fast/images/animated-large-image-different-dest-size-expected.txt
    A LayoutTests/fast/images/animated-large-image-different-dest-size.html
    A LayoutTests/fast/images/resources/animated-red-green-blue-1000x1000-infinite.gif
    M Source/WebCore/platform/graphics/BitmapImage.h
    M Source/WebCore/platform/graphics/BitmapImageSource.cpp
    M Source/WebCore/platform/graphics/BitmapImageSource.h
    M Source/WebCore/platform/graphics/ImageSource.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  REGRESSION(276827 at main): A large animated image will flicker if it's displayed multiple times with different sizes
https://bugs.webkit.org/show_bug.cgi?id=274671
rdar://128557319

Reviewed by Simon Fraser.

If the image is an animated image and the current frame is not available, we have
no choice but to decode it synchronously. Otherwise, a flicker will happen. This
was the BitmapImage::draw() behavior before 276827 at main.

* LayoutTests/fast/images/animated-large-image-different-dest-size-expected.txt: Added.
* LayoutTests/fast/images/animated-large-image-different-dest-size.html: Added.
* LayoutTests/fast/images/resources/animated-red-green-blue-1000x1000-infinite.gif: Added.
* Source/WebCore/platform/graphics/BitmapImage.h:
* Source/WebCore/platform/graphics/BitmapImageSource.cpp:
(WebCore::BitmapImageSource::requestNativeImageAtIndexIfNeeded):
(WebCore::BitmapImageSource::nativeImageAtIndexCacheIfNeeded):
(WebCore::BitmapImageSource::nativeImageAtIndexRequestIfNeeded):
(WebCore::BitmapImageSource::nativeImageAtIndexForDrawing):
* Source/WebCore/platform/graphics/BitmapImageSource.h:
(WebCore::BitmapImageSource::decodeCountForTesting const): Deleted.
* Source/WebCore/platform/graphics/ImageSource.h:
(WebCore::ImageSource::blankDrawCountForTesting const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::imageBlankDrawCount):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/279483@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications