[webkit-changes] [WebKit/WebKit] 37d347: [Monterey] Videos don't fully render in LinkedIn n...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37d3475208d6a5f45271240c735fb81af0afaa88
      https://github.com/WebKit/WebKit/commit/37d3475208d6a5f45271240c735fb81af0afaa88
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  -----------
  [Monterey] Videos don't fully render in LinkedIn news feed
https://bugs.webkit.org/show_bug.cgi?id=274812
rdar://127264745

Reviewed by Youenn Fablet.

Video frames were not presented as when a requestVideoFrameCallback operation is pending we do
not create the required AVSampleBufferDisplayLayer.
This is a regression from 252893 at main.
On OS that do not support [AVSBDL copyDisplayedPixelBuffer] (Monterey and earlier), we create
a WebCoreDecompressionSession in place of a AVSBDL to decode the video frames. But those frames
are never rendered to screen. The (incorrect) assumption was that when using rVFC we would always
use a canvas or WebGL context to paint the video frames.
For now we revert the line introduced by 252893 at main that while fixing rVFC broke playback.
rVFC was broken anyway on Monterey and earlier (you never get the expected frame).

No test, as we no longer have infrastructure in place to check on specific Monterey code path.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayerOrVideoRenderer const):

Canonical link: https://commits.webkit.org/279474@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications