[webkit-changes] [WebKit/WebKit] dc7f1c: In in-window mode, disable rewind on MSE videos an...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc7f1c2fadad4043a7ad33cf9e15092800805d29
      https://github.com/WebKit/WebKit/commit/dc7f1c2fadad4043a7ad33cf9e15092800805d29
  Author: Dana Estra <destra at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/controls/time-control.js
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
    M Source/WebCore/Modules/modern-media-controls/media/overflow-support.js
    M Source/WebCore/Modules/modern-media-controls/media/seek-support.js
    M Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js
    M Source/WebCore/Modules/modern-media-controls/media/skip-forward-support.js
    M Source/WebCore/Modules/modern-media-controls/media/status-support.js

  Log Message:
  -----------
  In in-window mode, disable rewind on MSE videos and disable seeking and fast forward on live videos
https://bugs.webkit.org/show_bug.cgi?id=274598
rdar://126924018

Reviewed by Jer Noble.

This patch removes the rewind button in in-window mode if a video source type is not HLS or
a file. It also removes the fast forward button and disables seeking if a video's duration
is long enough to likely be a live video. This patch uses a threshold of a one week
(604800 seconds).

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::inWindowFullscreen const):
(WebCore::MediaControlsHost::externalDeviceDisplayName const): Deleted.
(WebCore::MediaControlsHost::externalDeviceType const): Deleted.
(WebCore::MediaControlsHost::controlsDependOnPageScaleFactor const): Deleted.
(WebCore::MediaControlsHost::setControlsDependOnPageScaleFactor): Deleted.
(WebCore::MediaControlsHost::generateUUID): Deleted.
(WebCore::MediaControlsHost::shadowRootCSSText): Deleted.
(WebCore::MediaControlsHost::base64StringForIconNameAndType): Deleted.
(WebCore::MediaControlsHost::formattedStringForDuration): Deleted.
(): Deleted.
(WebCore::MediaControlsHost::showMediaControlsContextMenu): Deleted.
(WebCore::MediaControlsHost::sourceType const): Deleted.
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):

Canonical link: https://commits.webkit.org/279471@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications