[webkit-changes] [WebKit/WebKit] 5c3e81: Cherry-pick 279190 at main (f6f7e5b1258f). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c3e8148817aa35bd1ca9d18a955de08741b1cea
      https://github.com/WebKit/WebKit/commit/5c3e8148817aa35bd1ca9d18a955de08741b1cea
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  -----------
  Cherry-pick 279190 at main (f6f7e5b1258f). https://bugs.webkit.org/show_bug.cgi?id=274257

    [GStreamer] Silence GstVideoFrame leaks
    https://bugs.webkit.org/show_bug.cgi?id=274257
    <rdar://problem/128454923>

    Reviewed by Xabier Rodriguez-Calvar.

    The ImageGStreamer no longer holds a BitmapImage, but a PlatformImagePtr. A BitmapImage is now
    created by VideoFrameGStreamer when painting is required. The ImageGStreamerSkia implementation no
    longer holds the mapped GstVideoFrame because that keeps un-necessary references and file
    descriptors open, the needed plane data is copied instead.

    * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
    (WebCore::ensureDebugCategoryIsInitialized):
    (WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
    * Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h:
    (WebCore::ImageGStreamer::create):
    (WebCore::ImageGStreamer::image const):
    (WebCore::ImageGStreamer::rect):
    (WebCore::ImageGStreamer::createImage): Deleted.
    (WebCore::ImageGStreamer::image): Deleted.
    * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
    (WebCore::ImageGStreamer::ImageGStreamer):
    * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp:
    (WebCore::ImageGStreamer::ImageGStreamer):
    * Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:
    (WebCore::MediaSampleGStreamer::sample const):
    * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
    (WebCore::convertSampleToImage):
    (WebCore::VideoFrame::paintInContext):

    Canonical link: https://commits.webkit.org/279190@main

Canonical link: https://commits.webkit.org/274313.291@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications