[webkit-changes] [WebKit/WebKit] 0d9af4: _WKWebExtensionSQLiteStore object is being dealloc...

kiaraarose noreply at github.com
Wed May 29 14:44:26 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d9af47d152ce4be12e3ca78ca9685cab1720592
      https://github.com/WebKit/WebKit/commit/0d9af47d152ce4be12e3ca78ca9685cab1720592
  Author: Kiara Rose <kiara_rose at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm

  Log Message:
  -----------
  _WKWebExtensionSQLiteStore object is being deallocated before extension storage is removed
https://bugs.webkit.org/show_bug.cgi?id=274850
rdar://128907598

Reviewed by Timothy Hatcher and Brian Weinstein.

In Release builds, the _WKWebExtensionSQLiteStore object being used to remove extension storage
is being deallocated before we make the call to remove the extension data. To prevent this from
happening, don't use weakSelf in `deleteDatabaseWithCompletionHandler` to keep the object alive
longer.

* Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm:
(-[_WKWebExtensionSQLiteStore deleteDatabaseWithCompletionHandler:]):

Canonical link: https://commits.webkit.org/279465@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list