[webkit-changes] [WebKit/WebKit] 7a1fe3: Avoid saving extra register for IPInt JS->Wasm wra...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a1fe31ef5a7a4ebdbf52c296d76189fad22dd78
      https://github.com/WebKit/WebKit/commit/7a1fe31ef5a7a4ebdbf52c296d76189fad22dd78
  Author: Justin Michaud <jmichaud at igalia.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M JSTests/wasm/stress/cc-i32-kitchen-sink.js
    M JSTests/wasm/stress/cc-int-to-int-cross-module-with-exception.js
    M JSTests/wasm/stress/cc-int-to-int-cross-module.js
    M JSTests/wasm/stress/cc-int-to-int-memory.js
    M JSTests/wasm/stress/cc-int-to-int-no-jit.js
    M JSTests/wasm/stress/cc-int-to-int-tail-call.js
    M JSTests/wasm/stress/cc-int-to-int.js
    M Source/JavaScriptCore/jit/RegisterSet.cpp
    M Source/JavaScriptCore/llint/InPlaceInterpreter.cpp
    M Source/JavaScriptCore/llint/WebAssembly.asm
    M Source/JavaScriptCore/runtime/InitializeThreading.cpp
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.h
    M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp

  Log Message:
  -----------
  Avoid saving extra register for IPInt JS->Wasm wrappers.
https://bugs.webkit.org/show_bug.cgi?id=274043

Reviewed by Keith Miller and Yusuke Suzuki.

Adding this register to the pinned register set causes a bunch of places
to save it. We should just spill it inside the JS->WASM interpreted entry thunk.

* Source/JavaScriptCore/jit/RegisterSet.cpp:
(JSC::RegisterSetBuilder::wasmPinnedRegisters):
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::JSEntrypointInterpreterCallee::calleeSaveRegistersImpl):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::makeInterpretedJSToWasmCallee):

Canonical link: https://commits.webkit.org/279435@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications