[webkit-changes] [WebKit/WebKit] 4c7681: [view-transitions] Old snapshot for the root eleme...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c7681b6487b2aa3283a4b92ca2796874fe06f4b
      https://github.com/WebKit/WebKit/commit/4c7681b6487b2aa3283a4b92ca2796874fe06f4b
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-root-scrollbar-with-fixed-background-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-root-scrollbar-with-fixed-background.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/old-content-root-scrollbar-with-fixed-background-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/old-content-root-scrollbar-with-fixed-background.html
    R LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html
    R LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  [view-transitions] Old snapshot for the root element is misplaced when the page is scrolled.
https://bugs.webkit.org/show_bug.cgi?id=274403
<rdar://128406598>

Reviewed by Tim Nguyen.

This causes flashes on https://malcolmkee.com/blog/view-transition-api-in-react-app/#practical-use-cases

When capturing the root, the snapshot is of the visible viewport area, not the whole element.
Adjust the snapshot capture rect by the scroll position to account for this.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-root-scrollbar-with-fixed-background-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-root-scrollbar-with-fixed-background.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/old-content-root-scrollbar-with-fixed-background-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/old-content-root-scrollbar-with-fixed-background.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::snapshotElementVisualOverflowClippedToViewport):

Canonical link: https://commits.webkit.org/279432@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications