[webkit-changes] [WebKit/WebKit] 237b90: Add an early return if loading updated DNR rules f...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 237b90c1c756967c60ca644f02dcc13084364628
      https://github.com/WebKit/WebKit/commit/237b90c1c756967c60ca644f02dcc13084364628
  Author: Brian Weinstein <bweinstein at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm

  Log Message:
  -----------
  Add an early return if loading updated DNR rules fails
https://bugs.webkit.org/show_bug.cgi?id=274785
rdar://128749905

Reviewed by Timothy Hatcher.

Without this early return, we were both trying to roll back to a savepoint and commit the same savepoint,
and then we would call the completion handler more than once, leading to this crash.

These code paths should be mutually exclusive, so make sure to add an early return.

* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::updateDeclarativeNetRequestRulesInStorage):

Canonical link: https://commits.webkit.org/279426@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications