[webkit-changes] [WebKit/WebKit] 3abd48: [Remote Inspection] Adjust the heuristic when comp...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3abd48ae06eaeb85830aa83b2983cf0b80fefa15
      https://github.com/WebKit/WebKit/commit/3abd48ae06eaeb85830aa83b2983cf0b80fefa15
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M Source/WebCore/page/ElementTargetingController.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm

  Log Message:
  -----------
  [Remote Inspection] Adjust the heuristic when computing the adjustment rect count
https://bugs.webkit.org/show_bug.cgi?id=274810
rdar://128885913

Reviewed by Abrar Rahman Protyasha and Megan Gardner.

Make a minor adjustment to how we handle empty (or `display: none;`) elements when getting the total
adjustment rect count, so that they count towards the final result.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ElementTargetingController::numberOfVisibilityAdjustmentRects const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting, AdjustVisibilityFromSelectors)):

Canonical link: https://commits.webkit.org/279424@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications