[webkit-changes] [WebKit/WebKit] 8e0283: Adjust error-handling for invalid filter primitive...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e028375b9c5a9717932ec07c446b4d1b9704345
      https://github.com/WebKit/WebKit/commit/8e028375b9c5a9717932ec07c446b4d1b9704345
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M LayoutTests/css3/filters/invalid-reference-filter-in-chain.html
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
    M LayoutTests/svg/filters/feMerge-wrong-input-expected.txt
    A LayoutTests/svg/filters/in-attribute-error-handling-expected.html
    A LayoutTests/svg/filters/in-attribute-error-handling.html
    M Source/WebCore/svg/graphics/filters/SVGFilterGraph.h

  Log Message:
  -----------
  Adjust error-handling for invalid filter primitive references

https://bugs.webkit.org/show_bug.cgi?id=250276
rdar://problem/104262208

Reviewed by Simon Fraser and Darin Adler.

This patch aligns LegacySVG engine in WebKit with
Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/blink/+/ffa39ae78904542a2864e2cb7d1c16c24ee2324e

When a filter primitive has an 'in' (or, where applicable, 'in2') attribute
that references a non-existent result, treat that reference as having the
default value (==no value) instead of producing an error.

* Source/WebCore/svg/graphics/filters/SVGFilterGraph.h:
(WebCore::SVGFilterGraph::getNamedNode const):
* LayoutTests/svg/filters/in-attribute-error-handling.html: Add Test Case
* LayoutTests/svg/filters/in-attribute-error-handling-expected.html: Add Test Case Expectation
* LayoutTests/css3/filters/invalid-reference-filter-in-chain.html: Add Pixel Tolerance for GTK and WPE

> Rebaselines:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt:
* LayoutTests/svg/filters/feMerge-wrong-input-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt:

Canonical link: https://commits.webkit.org/279421@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications