[webkit-changes] [WebKit/WebKit] 827066: [WebDriver] Add confirmation of socket connection ...

Haruhisa SHIN noreply at github.com
Tue May 28 17:04:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 827066c642dd0139614ce43da695a13630da596f
      https://github.com/WebKit/WebKit/commit/827066c642dd0139614ce43da695a13630da596f
  Author: Haruhisa SHIN <haruhisa.shin at open-tec.co.jp>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M Source/WebDriver/SessionHost.cpp

  Log Message:
  -----------
  [WebDriver] Add confirmation of socket connection before sending commands to the backend
https://bugs.webkit.org/show_bug.cgi?id=274509

Reviewed by Carlos Garcia Campos.

The SessionHost of WebDriver is trying to send a command to backend
without checking whether the socket is connected or not.
If the socket is disconnected, the completionHandler will remain added
to the queue and will not be called by anyone, and the process will not
be completed.
To solve this problem, add code to check the status of the socket
before sending the command.

* Source/WebDriver/SessionHost.cpp:
(WebDriver::SessionHost::sendCommandToBackend):

Canonical link: https://commits.webkit.org/279417@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list