[webkit-changes] [WebKit/WebKit] 1560bc: [WebGPU] Auto layout incorrectly allows mismatched...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1560bc9c8d3f033453f813e557a9dffe16d4946c
      https://github.com/WebKit/WebKit/commit/1560bc9c8d3f033453f813e557a9dffe16d4946c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_274713-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274713.html
    A LayoutTests/fast/webgpu/regression/repro_274713b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274713b.html
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Auto layout incorrectly allows mismatched bindings
https://bugs.webkit.org/show_bug.cgi?id=274713
<radar://128681978>

Reviewed by Tadeu Zagallo.

Validate that mismatched bindings between fragment and vertex programs results
in a validation error.

* LayoutTests/fast/webgpu/regression/repro_274713-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274713.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274713b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274713b.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::BindGroupLayout::equalBindingEntries):
(WebGPU::equalEntries):
(WebGPU::equalBindingEntries): Deleted.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::makeBindingLayout):
(WebGPU::toBindingLayout):
(WebGPU::Device::addPipelineLayouts):

Canonical link: https://commits.webkit.org/279415@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications