[webkit-changes] [WebKit/WebKit] bb30fd: Crash with ruby and continuations

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb30fdac92be85496b875235c1372a152134ac22
      https://github.com/WebKit/WebKit/commit/bb30fdac92be85496b875235c1372a152134ac22
  Author: Robert Jenner <jenner at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    A LayoutTests/fast/ruby/ruby-continuation-crash-expected.txt
    A LayoutTests/fast/ruby/ruby-continuation-crash.html
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  -----------
  Crash with ruby and continuations
https://bugs.webkit.org/show_bug.cgi?id=271167
rdar://124432235

Reviewed by Ryosuke Niwa.

* LayoutTests/fast/ruby/ruby-continuation-crash-expected.txt: Added.
* LayoutTests/fast/ruby/ruby-continuation-crash.html: Added.
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers):

Improve robustness by using WeakPtr for destroyRoot and null checking before calling destroy(*destroyRoot)
as it might get deleted by an earlier destroy() call.

Originally-landed-as: 272448.763 at safari-7618-branch (df9629adcf83). rdar://128549808
Canonical link: https://commits.webkit.org/279408@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications