[webkit-changes] [WebKit/WebKit] 9b9256: [WebGPU] CommandsMixin::computedSizeOverflows does...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b92567e1389cae708ba091fe3df496b9a471627
      https://github.com/WebKit/WebKit/commit/9b92567e1389cae708ba091fe3df496b9a471627
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandsMixin.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  -----------
  [WebGPU] CommandsMixin::computedSizeOverflows does not correctly handle overflow
https://bugs.webkit.org/show_bug.cgi?id=274782
<radar://128865893>

Reviewed by Tadeu Zagallo.

Handle overflow in case a value greater than 2^53 - 1 is passed to these
functions.

Attempted to write a test but since 2^53 - 1 is the max value for Number
in JavaScript, this issue is only reproducible when sending messages directly
from the IPC layer.

* Source/WebGPU/WebGPU/CommandsMixin.mm:
(WebGPU::CommandsMixin::computedSizeOverflows):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::setVertexBuffer):

Canonical link: https://commits.webkit.org/279401@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications