[webkit-changes] [WebKit/WebKit] 29d113: [WGSL] shader, execution, expression, unary, address_o...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29d113f326172fe15e5e79df5f4e600c52b418c9
      https://github.com/WebKit/WebKit/commit/29d113f326172fe15e5e79df5f4e600c52b418c9
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/address_of_and_indirection-expected.txt
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] shader,execution,expression,unary,address_of_and_indirection:* is failing
https://bugs.webkit.org/show_bug.cgi?id=274754
rdar://128792671

Reviewed by Mike Wyrzykowski.

There were two issues:
- we weren't setting CallExpression::m_isConstructor for calls to struct and array
  constructors.
- we were not handling the case for index access on pointers in the code generator.
  i.e. `x[i]` needs to emit `(*x)[i]` when `x` is a pointer.

* LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/address_of_and_indirection-expected.txt: Added.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/279399@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications