[webkit-changes] [WebKit/WebKit] 825c23: [WebGPU] Integer overflow in RenderBundleEncoder::...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 825c235203559922b2b51bb8fd75758878b26f6b
      https://github.com/WebKit/WebKit/commit/825c235203559922b2b51bb8fd75758878b26f6b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_274703-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274703.html
    M Source/WebGPU/WebGPU/Buffer.h
    M Source/WebGPU/WebGPU/Buffer.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Integer overflow in RenderBundleEncoder::runIndexBufferValidation
https://bugs.webkit.org/show_bug.cgi?id=274703
<radar://128618591>

Reviewed by Tadeu Zagallo.

Use checked arithmetic to avoid overflow and out of bounds reads.

* LayoutTests/fast/webgpu/regression/repro_274703-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274703.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::maxIndex const): Deleted.
This was not being used, the values are computed using a shader now.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::runIndexBufferValidation):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::runIndexBufferValidation):

Canonical link: https://commits.webkit.org/279390@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications