[webkit-changes] [WebKit/WebKit] 932717: [Invalidation] Teardown root should take care of m...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93271739610fe9de4d1ad373c645ac298c792966
      https://github.com/WebKit/WebKit/commit/93271739610fe9de4d1ad373c645ac298c792966
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
    M Source/WebCore/rendering/updating/RenderTreeUpdater.h

  Log Message:
  -----------
  [Invalidation] Teardown root should take care of marking ancestors dirty on behalf of its subtree
https://bugs.webkit.org/show_bug.cgi?id=274658

Reviewed by Antti Koivisto.

Instead of calling setNeedsLayoutAndPrefWidthsRecalc on each and every renderer at teardown,
let's just dirty the parent of the destroy root and any renderer that skip the destroy root
as containing block.

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererStateOnDetach):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::repaintAndMarkContainingBlockDirtyBeforeTearDown):
(WebCore::RenderTreeUpdater::tearDownRenderers):
(WebCore::repaintBeforeTearDown): Deleted.

Canonical link: https://commits.webkit.org/279377@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications