[webkit-changes] [WebKit/WebKit] 2058ec: [view-transitions] Captured root element with marg...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2058eceb3fd5f84b7d394aa7281110088f9f62e1
      https://github.com/WebKit/WebKit/commit/2058eceb3fd5f84b7d394aa7281110088f9f62e1
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h

  Log Message:
  -----------
  [view-transitions] Captured root element with margins display snapshots in incorrect position.
https://bugs.webkit.org/show_bug.cgi?id=274397
<rdar://128405732>

Reviewed by Tim Nguyen.

If the root element is captured in the view transition, then we effectively do snapshotting
of the RenderView instead.

Computing the element-to-screen transform should be skipped, since it would include any
margin on the root element relative the view.

Most of the code in RenderLayerBacking that prepares a captured layer for attachment
into the pseduo element tree also needs to operate on the RenderView's layer in this case,
so a new 'effectiveCapturedInViewTransition' added to make this simpler.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::copyElementBaseProperties):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
(WebCore::RenderLayerBacking::shouldClipCompositedBounds const):
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::effectiveCapturedInViewTransition const):
* Source/WebCore/rendering/RenderObject.h:

Canonical link: https://commits.webkit.org/279372@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications