[webkit-changes] [WebKit/WebKit] 0fa174: [WebGPU] RemoteBuffer::copy can result in an out o...

mwyrzykowski noreply at github.com
Mon May 27 23:55:18 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fa174e18a820faa0c61c796fabe4288683a81d2
      https://github.com/WebKit/WebKit/commit/0fa174e18a820faa0c61c796fabe4288683a81d2
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_274678-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274678.html
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp
    M Source/WebGPU/WebGPU/Buffer.mm
    M Source/WebGPU/WebGPU/WebGPU.h

  Log Message:
  -----------
  [WebGPU] RemoteBuffer::copy can result in an out of bounds write
https://bugs.webkit.org/show_bug.cgi?id=274678
<radar://128591350>

Reviewed by Tadeu Zagallo.

RemoteBuffer::copy should use the actual buffer size, not the initial size.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp:
(WebCore::WebGPU::BufferImpl::getBufferContents):
* Source/WebGPU/WebGPU/Buffer.mm:
(wgpuBufferGetActualSize):
* Source/WebGPU/WebGPU/WebGPU.h:

* LayoutTests/fast/webgpu/regression/repro_274678-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274678.html: Added.
Add regression test for running locally.

Canonical link: https://commits.webkit.org/279368@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list