[webkit-changes] [WebKit/WebKit] 5a4a4b: [WebGPU] negative baseVertex is incorrectly handle...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a4a4bf47a3397f8b705bdf1c810a0d98c9fad9a
      https://github.com/WebKit/WebKit/commit/5a4a4bf47a3397f8b705bdf1c810a0d98c9fad9a
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_274687-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274687.html
    A LayoutTests/fast/webgpu/regression/repro_274687b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_274687b.html
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] negative baseVertex is incorrectly handled in drawIndexed calls
https://bugs.webkit.org/show_bug.cgi?id=274687
<radar://128601743>

Reviewed by Tadeu Zagallo.

Negative baseVertex is allowed and also fix a previous issue where an index
buffer containing a vertexId one past the end of the vertex buffer would not
get its draw discarded.

* LayoutTests/fast/webgpu/regression/repro_274687-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274687.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274687b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274687b.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/Device.mm:
Fix off by one.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::storeVertexBufferCountsForValidation):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
Allow negative baseVertex.

Canonical link: https://commits.webkit.org/279364@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications