[webkit-changes] [WebKit/WebKit] faa57a: Cherry-pick 279340 at main (d8fda146dfed). https://bu...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: faa57a90e5fb6a344d092293b70a92f1433e5222
      https://github.com/WebKit/WebKit/commit/faa57a90e5fb6a344d092293b70a92f1433e5222
  Author: Frances Cornwall <frances_c at cox.net>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.css

  Log Message:
  -----------
  Cherry-pick 279340 at main (d8fda146dfed). https://bugs.webkit.org/show_bug.cgi?id=274728

    Web Inspector: Missing a semicolon in MemoryTimelineOverviewGraph.css
    https://bugs.webkit.org/show_bug.cgi?id=274728

    Reviewed by Devin Rousso.

    There was a missing semicolon in line 38 in MemoryTimelineOverviewGraph.css.
    All CSS lines should have a semicolon at the end.

    * Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.css:
    (.timeline-overview-graph.memory > .legend):

    Canonical link: https://commits.webkit.org/279340@main

Canonical link: https://commits.webkit.org/274313.262@webkitglib/2.44


  Commit: 9132436cb35429962c86294c6cb484cd38988345
      https://github.com/WebKit/WebKit/commit/9132436cb35429962c86294c6cb484cd38988345
  Author: Frances Cornwall <frances_c at cox.net>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/RecordingContentView.css

  Log Message:
  -----------
  Cherry-pick 279323 at main (01b4b037edad). https://bugs.webkit.org/show_bug.cgi?id=274693

    Web Inspector: font-family should be font-size in RecordingContentView.css
    https://bugs.webkit.org/show_bug.cgi?id=274693

    Reviewed by Devin Rousso.

    I am deleting font-family: 11px to in RecordingContentView.css.
    The font-size is not being applied due to the above font-family overriding it.

    * Source/WebInspectorUI/UserInterface/Views/RecordingContentView.css:
    (.content-view.recording > header > .slider-container > .slider-value):

    Canonical link: https://commits.webkit.org/279323@main

Canonical link: https://commits.webkit.org/274313.263@webkitglib/2.44


  Commit: 45158558e3d50e74ab7c0f68ba6cb7ed3ed1ceec
      https://github.com/WebKit/WebKit/commit/45158558e3d50e74ab7c0f68ba6cb7ed3ed1ceec
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ViewGestureController.cpp

  Log Message:
  -----------
  Cherry-pick 279322 at main (0b0856901df8). https://bugs.webkit.org/show_bug.cgi?id=274710

    UI process crash due to null pointer dereference under ViewGestureController::applyMagnification()
    https://bugs.webkit.org/show_bug.cgi?id=274710
    rdar://128521737

    Reviewed by Wenson Hsieh.

    We have received a few crash reports with the following signature:

    ```
    Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
    Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
    Exception Codes:       0x0000000000000001, 0x0000000000000000

    Thread 0 Crashed::   Dispatch queue: com.apple.main-thread
    0   com.apple.WebKit                       0x1ada630ec WebKit::ViewGestureController::applyMagnification() + 208
    1   com.apple.WebKit                       0x1ad8dee50 WebKit::ViewGestureController::handleMagnificationGestureEvent(NSEvent*, WebCore::FloatPoint) + 296
    2   com.apple.WebKit                       0x1ad9160e4 WebKit::WebViewImpl::magnifyWithEvent(NSEvent*) + 164
    ```

    ... which is simply a null pointer dereference in applyMagnification().
    The only pointer dereference in that function occurs on the
    DrawingAreaProxy, so let's speculatively guard said dereference.

    * Source/WebKit/UIProcess/ViewGestureController.cpp:
    (WebKit::ViewGestureController::applyMagnification):

    Canonical link: https://commits.webkit.org/279322@main

Canonical link: https://commits.webkit.org/274313.264@webkitglib/2.44


  Commit: 6f733fdfb8d2b32e7eb372da8a1bcdbef46f1387
      https://github.com/WebKit/WebKit/commit/6f733fdfb8d2b32e7eb372da8a1bcdbef46f1387
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebCore/platform/text/SegmentedString.h

  Log Message:
  -----------
  Cherry-pick 279306 at main (8bea440e85a6). https://bugs.webkit.org/show_bug.cgi?id=274677

    WTF::SegmentedString::Substring has uninitialized fields when m_length == 0
    <https://bugs.webkit.org/show_bug.cgi?id=274677>
    <rdar://128696520>

    Reviewed by Yusuke Suzuki.

    * Source/WebCore/platform/text/SegmentedString.h:
    (WTF::SegmentedString::Substring):
    - Provide default values for currentCharacter8 and is8Bit.

    Canonical link: https://commits.webkit.org/279306@main

Canonical link: https://commits.webkit.org/274313.265@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/8863ceb3c848...6f733fdfb8d2

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications