[webkit-changes] [WebKit/WebKit] ae3780: [Cococa] Ensure temporary PDF file paths are writt...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae3780f0dcc35faca0a21110e00f5955a0cd00c7
      https://github.com/WebKit/WebKit/commit/ae3780f0dcc35faca0a21110e00f5955a0cd00c7
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm

  Log Message:
  -----------
  [Cococa] Ensure temporary PDF file paths are written matching the meaning of their relevant file URLs
https://bugs.webkit.org/show_bug.cgi?id=274695
<rdar://127379128>

Reviewed by Abrar Rahman Protyasha.

Correct pathToPDFOnDisk so that it creates un-encoded files from file URLs, since NSWorkspace
always decodes it's URL path arguments before passing to relevant helper applications to open.

This ensures that an attempt to open a temporary file for a PDF like "some%20test.pdf" will
create a temporary "some\ test.pdf" on disk, which will then be found by NSWorkspace when it
is given the encoded file URL.

* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::pathToPDFOnDisk):

Canonical link: https://commits.webkit.org/279359@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications