[webkit-changes] [WebKit/WebKit] 77548f: [WPE][run-benchmark] The browser is not terminated...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77548fd93ab480259f2d3644c7c63cb6f947c01e
      https://github.com/WebKit/WebKit/commit/77548fd93ab480259f2d3644c7c63cb6f947c01e
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py

  Log Message:
  -----------
  [WPE][run-benchmark] The browser is not terminated when there is a timeout
https://bugs.webkit.org/show_bug.cgi?id=274649

Reviewed by Carlos Garcia Campos.

I have been observing lot of timeouts on the benchmarks that are run at the WPE perf bots
https://build.webkit.org/#/builders/WPE-Linux-RPi4-64bits-Mesa-Release-Perf-Tests

The problem is caused because we run several benchmark plans in serial and when one of this
plans timeouts the runner exits without killing the browser, which means that the browser stays
on the screen.
So on the next run for the next benchmark the new browser invoked can't run (hangs forever)
because of the specific hardware configuration of this boards (WPE with DRM plugin; only one
browser allowed to hold a handle of the screen at a time)

So we need to ensure to terminate the current browser when the runner ends.

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.diagnose_test_failure):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:
(CogBrowserDriver.launch_url):

Canonical link: https://commits.webkit.org/279349@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications