[webkit-changes] [WebKit/WebKit] a34fd9: [WGSL] shader, execution, expression, constructor, non...
Tadeu Zagallo
noreply at github.com
Mon May 27 03:13:56 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a34fd9fade1fc5f2de8097a8418ca66be3a57501
https://github.com/WebKit/WebKit/commit/a34fd9fade1fc5f2de8097a8418ca66be3a57501
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2024-05-27 (Mon, 27 May 2024)
Changed paths:
A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/constructor/non_zero-expected.txt
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
Log Message:
-----------
[WGSL] shader,execution,expression,constructor,non_zero:* is still failing
https://bugs.webkit.org/show_bug.cgi?id=274600
rdar://128624933
Reviewed by Mike Wyrzykowski.
I fixed the tests in 278991 at main, but didn't update the expectations as it required
updating the CTS tests first, and the tests got broken before I could update it.
The fix was fairly simple, we just weren't generating the PackedVec3 struct for a
couple tests that needed it, which was fixed by changing where we detect that we
need to generate the struct.
* LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/constructor/non_zero-expected.txt: Added.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::pack):
(WGSL::RewriteGlobalVariables::packArrayResource):
(WGSL::RewriteGlobalVariables::packArrayType):
Canonical link: https://commits.webkit.org/279342@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list