[webkit-changes] [WebKit/WebKit] c76070: Add HasStrongDirectionalityContent info to InlineT...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7607058fef0eb7aae23b7bb2a5a04a6d26e7922
      https://github.com/WebKit/WebKit/commit/c7607058fef0eb7aae23b7bb2a5a04a6d26e7922
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-05-26 (Sun, 26 May 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/layouttree/LayoutInlineTextBox.h
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.h
    M Source/WebCore/rendering/RenderText.h

  Log Message:
  -----------
  Add HasStrongDirectionalityContent info to InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=274720
rdar://128745312

Reviewed by Alan Baradlay.

We already cached m_hasStrongDirectionalityContent information in RenderText as the same to m_hasPositionDependentContentWidth.
Let's just use this information to offer this information to Layout::InlineTextBox. And we skip repeated calls of containsStrongDirectionalityText.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::requiresVisualReordering):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::hasPositionDependentContentWidth):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::createLayoutBox):
(WebCore::LayoutIntegration::updateContentCharacteristic):
(WebCore::LayoutIntegration::BoxTree::updateContent):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:
(WebCore::Layout::InlineTextBox::hasStrongDirectionalityContent const):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.h:
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::setHasStrongDirectionalityContent):
(WebCore::RenderText::hasStrongDirectionalityContent const):

Canonical link: https://commits.webkit.org/279332@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications