[webkit-changes] [WebKit/WebKit] 6cd33f: Canvas drawImage() API does not throw an exception...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6cd33ff4b3a131cdb0b0061bc48daac568537fe4
      https://github.com/WebKit/WebKit/commit/6cd33ff4b3a131cdb0b0061bc48daac568537fe4
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-05-25 (Sat, 25 May 2024)

  Changed paths:
    M LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled-expected.txt
    M LayoutTests/http/tests/lazyload/placeholder.js
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.nonexistent-expected.txt
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h

  Log Message:
  -----------
  Canvas drawImage() API does not throw an exception when the image is in broken state
https://bugs.webkit.org/show_bug.cgi?id=274575
rdar://128588063

Reviewed by Kimmo Kinnunen.

If the image source is HTMLOrSVGImageElement and the image in a broken state,
canvas drawImage() should throw an exception.

Canvas image sources specifications:
https://html.spec.whatwg.org/multipage/canvas.html#image-sources-for-2d-rendering-contexts

* LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled-expected.txt:
* LayoutTests/http/tests/lazyload/placeholder.js:
(is_image_fully_loaded):
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.nonexistent-expected.txt:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImage):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:

Canonical link: https://commits.webkit.org/279319@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications