[webkit-changes] [WebKit/WebKit] fdbf2f: [WebGPU] PipelineLayout::errorValidatingBindGroupC...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fdbf2f66e2666d2d77377bf9200f2eed494d7e69
      https://github.com/WebKit/WebKit/commit/fdbf2f66e2666d2d77377bf9200f2eed494d7e69
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_1323-274609-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1323-274609.html
    A LayoutTests/fast/webgpu/regression/repro_1323b-274609-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1323b-274609.html
    A LayoutTests/fast/webgpu/regression/repro_1323c-274609-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1323c-274609.html
    M Source/WebGPU/WebGPU/PipelineLayout.mm

  Log Message:
  -----------
  [WebGPU] PipelineLayout::errorValidatingBindGroupCompatibility erroneously looks at stage_in vertex buffers counts
https://bugs.webkit.org/show_bug.cgi?id=274609
<radar://128596599>

Reviewed by Dan Glastonbury.

The `+ vertexStageInBufferCount` in the validation is incorrect, removing
it appears to cause zero regressions and fixes the below regression tests.

* LayoutTests/fast/webgpu/repro_1323-274609-expected.txt: Added.
* LayoutTests/fast/webgpu/repro_1323-274609.html: Added.
* LayoutTests/fast/webgpu/repro_1323b-274609-expected.txt: Added.
* LayoutTests/fast/webgpu/repro_1323b-274609.html: Added.
* LayoutTests/fast/webgpu/repro_1323c-274609-expected.txt: Added.
* LayoutTests/fast/webgpu/repro_1323c-274609.html: Added.
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const):

Canonical link: https://commits.webkit.org/279308@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications