[webkit-changes] [WebKit/WebKit] d61142: Toggling visibility:hidden on the parent of a <can...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6114259cba014fee42ac469271069b0c4f887d4
      https://github.com/WebKit/WebKit/commit/d6114259cba014fee42ac469271069b0c4f887d4
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    A LayoutTests/compositing/canvas/copy-backing-store-visibility-hidden-expected.html
    A LayoutTests/compositing/canvas/copy-backing-store-visibility-hidden.html
    M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  -----------
  Toggling visibility:hidden on the parent of a <canvas> can cause the previous frame's contents to be shown.
https://bugs.webkit.org/show_bug.cgi?id=274262
<rdar://128226178>

Reviewed by Simon Fraser.

We should only try to use 'copy' compositing mode to transfer the canvas buffer into the layer (and thus
omit any pixel clearing) if there is visible content to copy.

* LayoutTests/compositing/canvas/copy-backing-store-visibility-hidden-expected.html: Added.
* LayoutTests/compositing/canvas/copy-backing-store-visibility-hidden.html: Added.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):

Canonical link: https://commits.webkit.org/279302@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications