[webkit-changes] [WebKit/WebKit] fe5976: Remove 'presentational hints' from `width` attribu...

Commit Queue noreply at github.com
Thu May 23 17:11:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe5976c30783e180bab3de912da826c196d0b079
      https://github.com/WebKit/WebKit/commit/fe5976c30783e180bab3de912da826c196d0b079
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt
    M Source/WebCore/html/HTMLHRElement.cpp

  Log Message:
  -----------
  Remove 'presentational hints' from `width` attribute for `<hr>`

https://bugs.webkit.org/show_bug.cgi?id=274605

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Gecko / Firefox and web specification [1]:

[1] https://html.spec.whatwg.org/#the-hr-element-2

"The width attribute on an hr element maps to the dimension property 'width' on the element."

As per above, there should not be any presentational hints'. Hence, this
patch removes them from WebKit's codebase.

* Source/WebCore/html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectPresentationalHintsForAttribute):
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt: Rebaseline

Canonical link: https://commits.webkit.org/279245@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list