[webkit-changes] [WebKit/WebKit] d59731: Use nw_context_privacy_level_silent for DNS lookup

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5973196a382a1964fe1eed6843bad33c3aa449b
      https://github.com/WebKit/WebKit/commit/d5973196a382a1964fe1eed6843bad33c3aa449b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
    M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp

  Log Message:
  -----------
  Use nw_context_privacy_level_silent for DNS lookup
https://bugs.webkit.org/show_bug.cgi?id=272190
rdar://120452086

Reviewed by Matthew Finkel, Brent Fulgham and Youenn Fablet.

DNSServiceGetAddrInfo logs the domain name in internal builds, which is undesirable
when using WKWebsiteDataStore.nonPersistentDataStore.  This redacts those logs.
Public OSes should be unaffected.

* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp:
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::complete):
(WebCore::extractIPAddress):
(WebCore::DNSResolveQueueCFNet::performDNSLookup):
(WebCore::DNSResolveQueueCFNet::stopResolve):
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::addIPAddress): Deleted.
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::receivedIPv4AndIPv6 const): Deleted.
(): Deleted.
(WebCore::dnsLookupCallback): Deleted.

Originally-landed-as: 272448.889 at safari-7618-branch (7e9184c87123). rdar://128570639
Canonical link: https://commits.webkit.org/279199@main


  Commit: ee944cef38abdeeb7412f74137811c1e46e106c7
      https://github.com/WebKit/WebKit/commit/ee944cef38abdeeb7412f74137811c1e46e106c7
  Author: Darryl Parkinson <d_parkinson at apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/Editor.h
    M Source/WebCore/editing/cocoa/EditorCocoa.mm
    M Source/WebCore/editing/ios/EditorIOS.mm
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/page/EditorClient.h
    M Source/WebCore/platform/Pasteboard.h
    M Source/WebCore/platform/PasteboardWriterData.h
    M Source/WebCore/platform/PromisedAttachmentInfo.h
    M Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
    M Source/WebCore/platform/mac/PasteboardMac.mm
    M Source/WebCore/platform/mac/PasteboardWriter.mm
    M Source/WebKit/Shared/Pasteboard.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm

  Log Message:
  -----------
  Change 2 related Vectors to use Vector Pair to prevent OOB.
rdar://122621756

Reviewed by Ryosuke Niwa, Alex Christensen and Brady Eidson

Changing two related Vectors to use a Vector pair which means they are always the same length, preventing an OOB on one of the vectors.
* Source/WebKit/Shared/Pasteboard.serialization.in:

Originally-landed-as: 272448.899 at safari-7618-branch (48d5c62d7d15). rdar://128570706
Canonical link: https://commits.webkit.org/279200@main


  Commit: 1d943e49ba8542867bbf3238ada5e64a05201449
      https://github.com/WebKit/WebKit/commit/1d943e49ba8542867bbf3238ada5e64a05201449
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebCore/SerializedScriptValue.cpp

  Log Message:
  -----------
  Removing unbounded resize of Vector
https://bugs.webkit.org/show_bug.cgi?id=272491
rdar://126132559

Reviewed by Alex Christensen.

Resize the vector with an option to fallback to default value.
Test Case has been added to verify the fix.

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readRTCCertificate):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebCore/SerializedScriptValue.cpp: Added.
(TestWebKitAPI::TEST):

Originally-landed-as: 272448.906 at safari-7618-branch (cb2f03208aa6). rdar://128571325
Canonical link: https://commits.webkit.org/279201@main


Compare: https://github.com/WebKit/WebKit/compare/7031a92238c3...1d943e49ba85

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications