[webkit-changes] [WebKit/WebKit] e67dd6: [GStreamer] Move most GStreamerCommon classes impl...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e67dd6f289db6671b04a9f74c47dc54cd266c257
      https://github.com/WebKit/WebKit/commit/e67dd6f289db6671b04a9f74c47dc54cd266c257
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp

  Log Message:
  -----------
  [GStreamer] Move most GStreamerCommon classes implemenations to cpp file
https://bugs.webkit.org/show_bug.cgi?id=274524

Reviewed by Xabier Rodriguez-Calvar.

The GStreamerCommon.h file is included in many other files, so any change there triggers ~950
compile jobs on an incremental build. The template classes were left in the header, moving them to
the cpp file would increase verbosity too much. Also driving-by a couple GstMappedFrame methods were
renamed, adopting the camelCase style.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::GstMappedOwnedBuffer::create):
(WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer):
(WebCore::GstMappedOwnedBuffer::createSharedBuffer):
(WebCore::GstMappedFrame::GstMappedFrame):
(WebCore::GstMappedFrame::~GstMappedFrame):
(WebCore::GstMappedFrame::get):
(WebCore::GstMappedFrame::componentData const):
(WebCore::GstMappedFrame::componentStride const):
(WebCore::GstMappedFrame::info):
(WebCore::GstMappedFrame::width const):
(WebCore::GstMappedFrame::height const):
(WebCore::GstMappedFrame::format const):
(WebCore::GstMappedFrame::planeData const):
(WebCore::GstMappedFrame::planeStride const):
(WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer):
(WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer):
(WebCore::GstMappedAudioBuffer::get):
(WebCore::GstMappedAudioBuffer::info):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::unmapFunction):
(WebCore::GstMappedOwnedBuffer::create): Deleted.
(WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer): Deleted.
(WebCore::GstMappedFrame::GstMappedFrame): Deleted.
(WebCore::GstMappedFrame::~GstMappedFrame): Deleted.
(WebCore::GstMappedFrame::get): Deleted.
(WebCore::GstMappedFrame::ComponentData const): Deleted.
(WebCore::GstMappedFrame::ComponentStride const): Deleted.
(WebCore::GstMappedFrame::info): Deleted.
(WebCore::GstMappedFrame::width const): Deleted.
(WebCore::GstMappedFrame::height const): Deleted.
(WebCore::GstMappedFrame::format const): Deleted.
(WebCore::GstMappedFrame::planeData const): Deleted.
(WebCore::GstMappedFrame::planeStride const): Deleted.
(WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer): Deleted.
(WebCore::GstMappedAudioBuffer::get): Deleted.
(WebCore::GstMappedAudioBuffer::info): Deleted.
(WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer): Deleted.
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrame::copyTo):
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerVideoFrameLibWebRTC::ToI420):

Canonical link: https://commits.webkit.org/279191@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications