[webkit-changes] [WebKit/WebKit] 354d46: RenderLayer : Unbalanced begin/endTransparencyLaye...

[darryl-apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 354d46a613b7dd92b44cd2d770f52127b33e546c
      https://github.com/WebKit/WebKit/commit/354d46a613b7dd92b44cd2d770f52127b33e546c
  Author: Nisha Jain <nisha_jain at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    A LayoutTests/fast/rendering/render-layer-with-providedbacking-crash-expected.txt
    A LayoutTests/fast/rendering/render-layer-with-providedbacking-crash.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  RenderLayer : Unbalanced begin/endTransparencyLayers with nested masked elements and backing sharing causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=269865
rdar://113144444.

Reviewed by Simon Fraser.

In order to balance the begin/endTransparencyLayers call for a TransparencyLayer with nested masked elements and backing sharing, added 'provided backing/paint to' into account while doing 'ancestor' traversal.

* LayoutTests/fast/rendering/render-layer-with-providedbacking-crash-expected.txt: Added.
* LayoutTests/fast/rendering/render-layer-with-providedbacking-crash.html: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::transparentPaintingAncestor):

Originally-landed-as: 272448.600 at safari-7618-branch (fc090f6ee88d). rdar://128545892
Canonical link: https://commits.webkit.org/279158@main


  Commit: 6398a57fc5a53f9fed588bfd32a13a8f55285ca0
      https://github.com/WebKit/WebKit/commit/6398a57fc5a53f9fed588bfd32a13a8f55285ca0
  Author: Scott Marcy <mscott at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/ipc/removeMediaUsageManagerSession-test-expected.txt
    A LayoutTests/ipc/removeMediaUsageManagerSession-test.html

  Log Message:
  -----------
  Adds a simplified test case to verify an over-release in ScreenTime is fixed.
https://bugs.webkit.org/show_bug.cgi?id=270461
rdar://115279815

Reviewed by David Kilzer.

This test is currently disabled in TestExpectations due to rdar://120486467 (Provide a way to notify WebKitTestRunner when we hit a purposeful MESSAGE_CHECK (267714)).

* LayoutTests/TestExpectations:
* LayoutTests/ipc/removeMediaUsageManagerSession-test-expected.txt: Added.
* LayoutTests/ipc/removeMediaUsageManagerSession-test.html: Added.

Originally-landed-as: 272448.683 at safari-7618-branch (6e9c0ea8de57). rdar://128546108
Canonical link: https://commits.webkit.org/279159@main


  Commit: d8547c86a7407a7a4e6e39c82773391be270d94f
      https://github.com/WebKit/WebKit/commit/d8547c86a7407a7a4e6e39c82773391be270d94f
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    A LayoutTests/security/schedule-request-object-then-disconnect-crash-expected.txt
    A LayoutTests/security/schedule-request-object-then-disconnect-crash.html

  Log Message:
  -----------
  Add test case for object loading crash
https://bugs.webkit.org/show_bug.cgi?id=268771
rdar://121959099

Reviewed by Ryosuke Niwa.

This test case applies to this bug as well as bug 264626, meaning it will crash
without the fix from bug 264626. Note that it makes more sense to land this test
than the one from bug 264626 as that one is flaky and this one is small and
reproduces every time.

* LayoutTests/security/schedule-request-object-then-disconnect-crash-expected.txt: Added.
* LayoutTests/security/schedule-request-object-then-disconnect-crash.html: Added.

Originally-landed-as: 274097.11 at webkit-2024.2-embargoed (22a024aa0b40). rdar://128546360
Canonical link: https://commits.webkit.org/279160@main


  Commit: 345a36c5552dab4470ceb58265f42188094d0b0d
      https://github.com/WebKit/WebKit/commit/345a36c5552dab4470ceb58265f42188094d0b0d
  Author: Darryl Parkinson <d_parkinson at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M Source/WebCore/workers/service/server/SWServerWorker.cpp
    M Source/WebCore/workers/service/server/SWServerWorker.h
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h

  Log Message:
  -----------
  Ensure that the SWServerWorker is in the correct state before finishing installation
rdar://121429889

Reviewed by Youenn Fablet.

Ensure that the SWServerWorker is in the expected state and bail if this method is triggered on a SWServerWorker in a different state. This method is callable over CoreIPC passing a ServiceWorkerIdentifier. Passing the ID of a service worker in any other state will reach the RELEASE_ASSERT

* Source/WebCore/workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::didFinishInstall):

Originally-landed-as: 272448.701 at safari-7618-branch (be630dbb12c9). rdar://128546484
Canonical link: https://commits.webkit.org/279161@main


Compare: https://github.com/WebKit/WebKit/compare/b287b6cc9662...345a36c5552d

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications