[webkit-changes] [WebKit/WebKit] ac7aec: Videos in in-window mode should have their WebKitP...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac7aecf284923b3ad201b085a68b66a1d614b285
      https://github.com/WebKit/WebKit/commit/ac7aecf284923b3ad201b085a68b66a1d614b285
  Author: Dana Estra <destra at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
    M Source/WebCore/html/HTMLVideoElement.cpp
    M Source/WebCore/html/HTMLVideoElement.h
    M Source/WebCore/html/HTMLVideoElement.idl

  Log Message:
  -----------
  Videos in in-window mode should have their WebKitPresentationMode property set to inline
https://bugs.webkit.org/show_bug.cgi?id=274477
rdar://128482499

Reviewed by Jer Noble.

This fix adds a method HTMLVideoElement::webkitPresentationModeForBindings(). The
default media controls now consult MediaControlsHost::inWindowFullscreen() to
determine that a video is in in-window mode.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::inWindowFullscreen const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.get isFullscreen):
(MediaController.prototype._updateControlsIfNeeded):
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitPresentationModeForBindings const):
* Source/WebCore/html/HTMLVideoElement.h:
* Source/WebCore/html/HTMLVideoElement.idl:

Canonical link: https://commits.webkit.org/279143@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications