[webkit-changes] [WebKit/WebKit] 19697c: [UnifiedPDF] Add the concept of "rows" to PDFDocum...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19697c5f3ef870f6c4ab84937a06156ee11d0a53
      https://github.com/WebKit/WebKit/commit/19697c5f3ef870f6c4ab84937a06156ee11d0a53
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Add the concept of "rows" to PDFDocumentLayout
https://bugs.webkit.org/show_bug.cgi?id=274496
rdar://128504528

Reviewed by Abrar Rahman Protyasha.

Discrete (non-scrolling) mode makes heavy use of the "row" concept, where
a row is a set of one or two pages viewed together. So introduce PDFLayoutRow,
and pass an optional row argument to nearestPageIndexForDocumentPoint().

Other namespace-related cleanup and utility additions for rows.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
(WebKit::PDFDocumentLayout::isSinglePageDisplayMode):
(WebKit::PDFDocumentLayout::isTwoUpDisplayMode):
(WebKit::PDFDocumentLayout::isScrollingDisplayMode):
(WebKit::PDFDocumentLayout::isDiscreteDisplayMode):
(WebKit::PDFDocumentLayout::isSinglePageDisplayMode const):
(WebKit::PDFDocumentLayout::isTwoUpDisplayMode const):
(WebKit::PDFDocumentLayout::isScrollingDisplayMode const):
(WebKit::PDFDocumentLayout::isDiscreteDisplayMode const):
(WebKit::PDFLayoutRow::numPages const):
(WebKit::PDFLayoutRow::containsPage const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::isRightPageIndex const):
(WebKit::PDFDocumentLayout::isLastPageIndex const):
(WebKit::PDFDocumentLayout::lastPageIndex const):
(WebKit::PDFDocumentLayout::isFirstPageOfRow const):
(WebKit::PDFDocumentLayout::indexForPage const):
(WebKit::PDFDocumentLayout::nearestPageIndexForDocumentPoint const):
(WebKit::PDFDocumentLayout::pageIndexAndPagePointForDocumentYOffset const):
(WebKit::PDFDocumentLayout::updateLayout):
(WebKit::PDFDocumentLayout::rowCount const):
(WebKit::PDFDocumentLayout::rows const):
(WebKit::PDFDocumentLayout::rowForPageIndex const):
(WebKit::PDFDocumentLayout::rowIndexForPageIndex const):
(WebKit::PDFDocumentLayout::layoutBoundsForRow const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::visibleRow const):
(WebKit::UnifiedPDFPlugin::shouldDisplayPage):
(WebKit::UnifiedPDFPlugin::indexForCurrentPageInView const):
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::continueAutoscroll):

Canonical link: https://commits.webkit.org/279135@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications