[webkit-changes] [WebKit/WebKit] 3a6e63: Fix linker error in JSC testing configuration

Keith Miller noreply at github.com
Wed May 22 08:39:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a6e636fb3bed4bda1a737658411a2af43c86e00
      https://github.com/WebKit/WebKit/commit/3a6e636fb3bed4bda1a737658411a2af43c86e00
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp
    M Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h

  Log Message:
  -----------
  Fix linker error in JSC testing configuration
https://bugs.webkit.org/show_bug.cgi?id=274523
rdar://128542072

Reviewed by Mark Lam.

It seems like someone holding a Ref/RefPtr to UnlinkedMetadataTable didn't
include the inlines header. Rather than figure out how to find the missing
include I just moved the destructor to the .cpp file. I don't think the
destructor is hot enough that inlining is needed.

* Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp:
(JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable):
* Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h:
(JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable): Deleted.

Canonical link: https://commits.webkit.org/279126@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list