[webkit-changes] [WebKit/WebKit] 59ee46: JetStreamDriver cli mode shouldn't print status if...

Keith Miller noreply at github.com
Tue May 21 18:36:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59ee4600231b781d7b520e4faebf0675a1780456
      https://github.com/WebKit/WebKit/commit/59ee4600231b781d7b520e4faebf0675a1780456
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M PerformanceTests/JetStream2/JetStreamDriver.js

  Log Message:
  -----------
  JetStreamDriver cli mode shouldn't print status if dumping JSON
https://bugs.webkit.org/show_bug.cgi?id=274487
rdar://128494817

Reviewed by Yusuke Suzuki.

Right now running the JetStream2 cli from the command line prints status updates
even when dumpJSONResults is truthy. This makes it hard to do
`jsc -e "dumpJSONResults=1" cli.js > results.json` since the top of the file
will have a bunch of status updates. This patch silences status updates when
dumpJSONResults is truthy.

Also, `customTestList` is now only intialized to `[]` if it's not already set so
we can now do `jsc -e "customTestList=['Air']" cli.js`

* PerformanceTests/JetStream2/JetStreamDriver.js:
(Driver.prototype.async start):
(prototype.updateUIBeforeRun):
(DefaultBenchmark.prototype.updateUIAfterRun):
(DefaultBenchmark):
(WSLBenchmark.prototype.updateUIAfterRun):
(WSLBenchmark):
(WasmBenchmark.prototype.updateUIAfterRun):
(WasmBenchmark):
(Driver.async fetchResources.statusElement.innerHTML.a.href.string_appeared_here):
(Driver.prototype.async fetchResources):

Canonical link: https://commits.webkit.org/279095@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list