[webkit-changes] [WebKit/WebKit] 743065: REGRESSION(278807 at main): [cairo] drawSurface shoul...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 743065037ceebd222ad05a002986edc71a43023f
      https://github.com/WebKit/WebKit/commit/743065037ceebd222ad05a002986edc71a43023f
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M LayoutTests/platform/wincairo/TestExpectations
    M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp

  Log Message:
  -----------
  REGRESSION(278807 at main): [cairo] drawSurface should clip the source rectangle to the source image
https://bugs.webkit.org/show_bug.cgi?id=274226

Reviewed by Don Olmstead.

After https://commits.webkit.org/278807@main removed the function
normalizeSourceAndDestination of CanvasRenderingContext2DBase.cpp,
layout tests fast/canvas/drawImage-source-rect-outside-image.html and
fast/canvas/drawImage-srcRect-clipping.html were failing for cairo
based ports.

The function adjusted the source rectangle and the destination
rectangle so that when the source rectangle is outside the source
image, the source rectangle should be clipped in the source image and
the destination rectangle should be clipped in the same proportion.

The function drawSurface of CairoOperations.cpp still needs the logic
for the subsurface code path.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:
(calculateSubsurfaceRect): Added.

Canonical link: https://commits.webkit.org/279075@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications