[webkit-changes] [WebKit/WebKit] 7307a6: Cherry-pick 278879 at main (9bf347ad34b3). https://bu...

[Carlos Bentzen]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 7307a61ea3c60278233a58a8f6f24098950cd825
      https://github.com/WebKit/WebKit/commit/7307a61ea3c60278233a58a8f6f24098950cd825
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  Cherry-pick 278879 at main (9bf347ad34b3). https://bugs.webkit.org/show_bug.cgi?id=273675

    Need to change the method for determining the number of CPUs on Linux
    https://bugs.webkit.org/show_bug.cgi?id=273675

    Reviewed by Carlos Garcia Campos.

    Try to use sysconf(_SC_NPROCESSORS_ONLN) on Linux to determine the
    amount of usable CPU cores. While Perl provides access to the function
    in its POSIX module, the _SC_NPROCESSORS_ONLN constant is not defined
    and the value of the constant is used instead. Using the value is fine
    as it is part of the user space API and not expected to ever change.
    As a fallback, make Perl parse /proc/cpuinfo directly instead of
    shelling out to a cat|grep pipeline: Perl knows how to regex and how
    to count just fine.

    * Tools/Scripts/webkitdirs.pm:
    (determineNumberOfCPUs): Replace usage of nproc command with sysconf,
    update /proc/cpuinfo parsing fallback.

    Canonical link: https://commits.webkit.org/278879@main

Canonical link: https://commits.webkit.org/274313.258@webkitglib/2.44


  Commit: e5549846369dc51be19b01b76feb4d2b812ff909
      https://github.com/WebKit/WebKit/commit/e5549846369dc51be19b01b76feb4d2b812ff909
  Author: Carlos Bentzen <cadubentzen at igalia.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    A LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt
    A LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  Cherry-pick 278099 at main (1bc81c31ff6c). https://bugs.webkit.org/show_bug.cgi?id=273318

    [WebRTC][GStreamer] Missing media in SDP if setConfiguration() is called after createDataChannel() or addTransceiver()
    https://bugs.webkit.org/show_bug.cgi?id=273318

    Reviewed by Xabier Rodriguez-Calvar.

    GStreamerMediaEndpoint::setConfiguration() was tearing down the pipeline
    if one already existed and creating a new one, which is an issue if any data channels
    or transceivers are created before RTCPeerConnection.setConfiguration().

    The issue is fixed by creating the pipeline earlier in GStreamerMediaEndpoint's contructor,
    so that data channels or transceivers aren't discarded if created/added before setConfiguration().

    Credit to Philippe Normand <philn at igalia.com> for finding the issue and fixing it.
    I wrote the layout test, which fails without his fix.

    * LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt: Added.
    * LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html: Added.
    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
    (WebCore::GStreamerMediaEndpoint::GStreamerMediaEndpoint):
    (WebCore::GStreamerMediaEndpoint::setConfiguration):

    Canonical link: https://commits.webkit.org/278099@main

Canonical link: https://commits.webkit.org/274313.259@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/c6f625d1c91d...e5549846369d

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications