[webkit-changes] [WebKit/WebKit] 7db834: [WGSL] Type checker does not handle shadowing of o...

Tadeu Zagallo noreply at github.com
Tue May 21 05:00:08 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7db8345cbe6b5da4ca87617e866b1f6bac6f4a65
      https://github.com/WebKit/WebKit/commit/7db8345cbe6b5da4ca87617e866b1f6bac6f4a65
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/function-call.wgsl

  Log Message:
  -----------
  [WGSL] Type checker does not handle shadowing of overloaded built-ins correctly
https://bugs.webkit.org/show_bug.cgi?id=274391
rdar://128202008

Reviewed by Mike Wyrzykowski.

The type checker incorrectly looked up the built-in definition even there was another
definition shadowing it.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/function-call.wgsl:

Canonical link: https://commits.webkit.org/279053@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list