[webkit-changes] [WebKit/WebKit] a3c503: [view-transitions] https://pokedex-dev.vercel.app/...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3c50349375a13f4f925ec6b5dba329ab1d5ac17
      https://github.com/WebKit/WebKit/commit/a3c50349375a13f4f925ec6b5dba329ab1d5ac17
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M Source/WebCore/css/MutableStyleProperties.cpp
    M Source/WebCore/css/MutableStyleProperties.h
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  -----------
  [view-transitions] https://pokedex-dev.vercel.app/pokemons has super low framerate.
https://bugs.webkit.org/show_bug.cgi?id=274439
<rdar://128030956>

Reviewed by Tim Nguyen.

We invalidate the stylesheet every frame, resulting in way too much painting.

Instead, only invalidate the stylesheet if we actually inserted new styles.
Also invalidate layout, and the layer configuration for the pseudo if we
change those.

* Source/WebCore/css/MutableStyleProperties.cpp:
(WebCore::MutableStyleProperties::mergeAndOverrideOnConflict):
* Source/WebCore/css/MutableStyleProperties.h:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::updatePseudoElementStyles):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::setSize):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/279049@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications