[webkit-changes] [WebKit/WebKit] 9dce2a: PublicSuffixStore::platformTopPrivatelyControlledD...

Chris Dumez noreply at github.com
Mon May 20 22:44:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9dce2ade92d582c9e7d6431ea8335a47d1985788
      https://github.com/WebKit/WebKit/commit/9dce2ade92d582c9e7d6431ea8335a47d1985788
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M Source/WebCore/platform/PublicSuffixStore.h
    M Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm
    M Source/WebCore/platform/network/curl/PublicSuffixStoreCurl.cpp
    M Source/WebCore/platform/soup/PublicSuffixStoreSoup.cpp

  Log Message:
  -----------
  PublicSuffixStore::platformTopPrivatelyControlledDomain() should take in a StringView
https://bugs.webkit.org/show_bug.cgi?id=274433

Reviewed by Ryosuke Niwa.

PublicSuffixStore::platformTopPrivatelyControlledDomain() should take in a StringView
instead of a String. It keeps calling substring(), which is a lot more efficient on a
StringView than a String.

* Source/WebCore/platform/PublicSuffixStore.h:
* Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm:
(WebCore::PublicSuffixStore::platformTopPrivatelyControlledDomain const):
* Source/WebCore/platform/network/curl/PublicSuffixStoreCurl.cpp:
(WebCore::PublicSuffixStore::platformTopPrivatelyControlledDomain const):
* Source/WebCore/platform/soup/PublicSuffixStoreSoup.cpp:
(WebCore::permissiveTopPrivateDomain):
(WebCore::PublicSuffixStore::platformTopPrivatelyControlledDomain const):

Canonical link: https://commits.webkit.org/279035@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list