[webkit-changes] [WebKit/WebKit] 876451: AX: must call WTF::switchOn on a copy of AXPropert...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8764515d00e935b61607b53d5dc20ea179d2ca06
      https://github.com/WebKit/WebKit/commit/8764515d00e935b61607b53d5dc20ea179d2ca06
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: must call WTF::switchOn on a copy of AXPropertyValueVariant
https://bugs.webkit.org/show_bug.cgi?id=274416
rdar://problem/128416654

Reviewed by Tyler Wilcock.

WTF::switchOn takes an rvalue reference (&&) so if we pass a value
to it directly, it can get moved.

In https://bugs.webkit.org/show_bug.cgi?id=273959 I changed a call to
WTF::switchOn to avoid an extra copy. For some types it was resulting
in moving the type away from the property map. Many isolated tree
tests failed as a result.

Let's revert this to fix things, but it'd be nice to figure out a
solution that's less fragile and doesn't require a copy just to access
a value from the property map.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
(WebCore::AXIsolatedObject::propertyValue const):

Canonical link: https://commits.webkit.org/279028@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications