[webkit-changes] [WebKit/WebKit] b1a076: [git-webkit] Reduce radar requests in clone

Jonathan Bedard noreply at github.com
Mon May 20 16:01:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1a07690232ffd27093173e2fd66cf65aa0ed777
      https://github.com/WebKit/WebKit/commit/b1a07690232ffd27093173e2fd66cf65aa0ed777
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py

  Log Message:
  -----------
  [git-webkit] Reduce radar requests in clone
https://bugs.webkit.org/show_bug.cgi?id=274216
rdar://128135181

Reviewed by Dewei Zhu.

Attempt to batch update requests on cloned radar, falling back to smaller updates if the
larger one fails.

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:
(RadarModel.commit_changes): Increment network call counter.
(RadarClient.radar_for_id): Ditto
(RadarClient.find_radars): Ditto
(RadarClient.milestones_for_component): Ditto
(RadarClient.find_components): Ditto
(RadarClient.create_radar): Ditto
(RadarClient.clone_radar): Ditto
(RadarClient.keywords_for_name): Ditto
(Radar.__init__): Keep track of function calls that result in network requests.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py:
(Clone.main): Attempt to batch all radar updates into a single request, falling back to smaller
updates if the batched update fails.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py:
(TestClone.test_no_reason): Check the number of radar network requests made during the program.
(TestClone.test_basic): Ditto.
(TestClone.test_no_prompt): Ditto.
(TestClone.test_prompt): Ditto.
(TestClone.test_merge_back_no_parent): Ditto.
(TestClone.test_merge_back): Ditto.
(TestClone.test_infer_merge_back): Ditto.

Canonical link: https://commits.webkit.org/279019@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list